[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 03/10] block: Assert no write requests under BDR
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING |
Date: |
Tue, 22 Dec 2015 13:27:34 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/22/2015 09:46 AM, Kevin Wolf wrote:
> As long as BDRV_O_INCOMING is set, the image file is only opened so we
> have a file descriptor for it. We're definitely not supposed to modify
> the image, it's still owned by the migration source.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
Based on the other thread going on, we may actually be able to hit this
assertion due to a latent bug:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01126.html
and maybe this assert will help us get a better stack trace to pinpoint
the culprit?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 00/10] qcow2: Implement image locking, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 02/10] qcow2: Write full header on image creation, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 01/10] qcow2: Write feature table only for v3 images, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING, Kevin Wolf, 2015/12/22
- Re: [Qemu-block] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING,
Eric Blake <=
- [Qemu-block] [PATCH 04/10] block: Fix error path in bdrv_invalidate_cache(), Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 05/10] block: Inactivate BDS when migration completes, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 07/10] qcow2: Implement .bdrv_inactivate, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 08/10] qcow2: Fix BDRV_O_INCOMING handling in qcow2_invalidate_cache(), Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 06/10] qemu-img: Prepare for locked images, Kevin Wolf, 2015/12/22