[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 14/21] blockdev: Set 'format' indicates non-e
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 14/21] blockdev: Set 'format' indicates non-empty drive |
Date: |
Fri, 4 Dec 2015 22:59:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 04.12.2015 14:35, Kevin Wolf wrote:
> Creating an empty drive while specifying 'format' doesn't make sense.
> The specified format driver would simply be ignored.
>
> Make a set 'format' option an indication that a non-empty drive should
> be created. This makes 'format' consistent with 'driver' and allows
> using it with a block driver that doesn't need any other options (like
> null-co/null-aio).
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 5 +----
> tests/hd-geo-test.c | 4 ++--
> tests/qemu-iotests/iotests.py | 2 +-
> 3 files changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 06/21] block: Exclude nested options only for children in append_open_options(), (continued)
- [Qemu-block] [PATCH v3 07/21] block: Pass driver-specific options to .bdrv_refresh_filename(), Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 09/21] block: Allow specifying child options in reopen, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 10/21] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 08/21] block: Keep "driver" in bs->options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 11/21] block: Add infrastructure for option inheritance, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 13/21] block: Introduce bs->explicit_options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 12/21] block: Split out parse_json_protocol(), Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 14/21] blockdev: Set 'format' indicates non-empty drive, Kevin Wolf, 2015/12/04
- Re: [Qemu-block] [PATCH v3 14/21] blockdev: Set 'format' indicates non-empty drive,
Max Reitz <=
- [Qemu-block] [PATCH v3 15/21] qemu-iotests: Remove cache mode test without medium, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 16/21] block: reopen: Extract QemuOpts for generic block layer options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 18/21] blkdebug: Enable reopen, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 17/21] block: Move cache options into options QDict, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 19/21] qemu-iotests: Try setting cache mode for children, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 21/21] qemu-iotests: Test reopen with node-name/driver options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 20/21] qemu-iotests: Test cache mode option inheritance, Kevin Wolf, 2015/12/04
- Re: [Qemu-block] [PATCH v3 00/21] block: Cache mode for children etc., Kevin Wolf, 2015/12/07