[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] tests: fix cdrom_pio_impl in ide-test
From: |
Peter Maydell |
Subject: |
Re: [Qemu-block] [PATCH] tests: fix cdrom_pio_impl in ide-test |
Date: |
Fri, 20 Nov 2015 14:37:43 +0000 |
On 20 November 2015 at 14:29, Peter Lieven <address@hidden> wrote:
> The check for the cleared BSY flag has to be performed
> before each data transfer and not just before the
> first one.
>
> Commit 5f81724d revealed this glitch as the BSY flag
> was not set in ATAPI PIO transfers before.
>
> While at it fix the desciptions and add a comment before
> the nested for loop that transfers the data.
>
> Signed-off-by: Peter Lieven <address@hidden>
If the IDE folks can review this I'd like to apply it
direct to master this afternoon so we can tag and roll rc1
today.
thanks
-- PMM