Re: [Qemu-block] [PATCH V5] block/nfs: add support for setting debug level

[Stefan Hajnoczi]

On Fri, Nov 13, 2015 at 01:19:55PM -0500, Jeff Cody wrote:
> On Fri, Nov 13, 2015 at 05:45:09PM +0800, Stefan Hajnoczi wrote:
> > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote:
> > > recent libnfs versions support logging debug messages. Add
> > > support for it in qemu through an URL parameter.
> > > 
> > > Example:
> > >  qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2
> > > 
> > > Signed-off-by: Peter Lieven <address@hidden>
> > > ---
> > > v4->v5: add a comment in the code why we limit the debug level [Stefan]
> > > v3->v4: revert to the initial version, but limit max debug level
> > > v2->v3: use a per-drive option instead of a global one. [Stefan]
> > > v1->v2: reworked patch to accept the debug level as a cmdline
> > >         parameter instead of an URI parameter [Stefan]
> > > 
> > >  block/nfs.c | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > 
> > Hi Peter,
> > Please use my official maintainer email address <address@hidden>
> > when CCing me.  I didn't spot the mail to GMail until after the QEMU 2.5
> > hard freeze deadline.
> > 
> > Only bug fixes are being merged for QEMU 2.5 now.  I'm sorry that this
> > patch didn't make it.  My block-next branch will be opening on Monday
> > and I'll merge this patch there for QEMU 2.6.
> >
> 
> Actually, this should go in through my branch, right?  I didn't see it
> before the hard freeze either (I was not on the cc list).  If you want
> to queue it that is fine, otherwise I'll add it to my 2.6 queue.

Yes:

$ scripts/get_maintainer.pl -f block/nfs.c
Jeff Cody <address@hidden> (maintainer:NFS)
Peter Lieven <address@hidden> (maintainer:NFS)
Kevin Wolf <address@hidden> (supporter:Block layer core)
address@hidden (open list:NFS)

I've been involved with the review of this series for a while and
overlooked it.

Stefan

signature.asc
Description: PGP signature