[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integer
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers |
Date: |
Mon, 16 Nov 2015 09:28:21 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Mon 16 Nov 2015 04:46:44 AM CET, Stefan Hajnoczi <address@hidden> wrote:
>> early_err:
>> qemu_opts_del(opts);
>> + QDECREF(interval_dict);
>> + QDECREF(interval_list);
>
> There is a codepath that reaches here without initializing interval_dict
> or interval_list:
>
> qemu_opts_absorb_qdict(opts, bs_opts, &error);
> if (error) {
> error_propagate(errp, error);
> goto early_err;
> }
You're right, I'll send a new version ASAP.
Berto