Re: [Qemu-block] [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

[Eric Blake]

On 11/11/2015 10:31 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
>> On 11/11/2015 07:21 AM, Markus Armbruster wrote:
>>> Eric Blake <address@hidden> writes:
>>>
>>>> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in
>>>> since c6bd8c706.  Nuke them.
>>>
>>> Doesn't really belong to this series, but that's okay.
>>
>> If you're going to modify this for 2.5 inclusion through your qerror
>> tree, you may want to change the description to:
> 
> I'll try to get this into 2.5 mostly for the documentation update.
> 
>> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) were missed in
>> c6bd8c706, or have snuck in since.  Nuke them.
> 
> Done.

Oh, and I missed your capitalization preferences in the title:

qerror: More error_setg() usage


>> There's also the question if we want to address the ErrorClass name
>> munging of 19/28 by adding your idea of an aliasing typedef in error.h;
>> if so, should I prepare a smaller patch series of both of those changes
>> for consideration for 2.5?
> 
> Can safely wait for 2.6, can't it?

Yes.  Just trying to make sure I'm focusing on 2.5 patches first.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature