[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v6 4/4] hmp: add monitor command to add/remove a
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v6 4/4] hmp: add monitor command to add/remove a child |
Date: |
Mon, 09 Nov 2015 15:54:46 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Fri 16 Oct 2015 10:57:46 AM CEST, Wen Congyang wrote:
> + .name = "blockdev_change",
> + .args_type = "op:s,parent:B,child:B?,node:?",
> + .params = "operation parent [child] [node]",
[...]
> + /*
> + * FIXME: we must specify the parameter child, otherwise,
> + * we can't specify the parameter node.
> + */
> + if (op == CHANGE_OPERATION_ADD) {
> + has_child = false;
> + }
So if you want to perform the 'add' operation you must pass both 'child'
and 'node' but the former will be discarded.
I don't think you really need to do this for the HMP interface, but it's
anyway one more good reason to merge 'child' and 'node'.
Berto
- Re: [Qemu-block] [PATCH v6 4/4] hmp: add monitor command to add/remove a child,
Alberto Garcia <=