[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 0/2] Don't allow snapshots if the overlay has parent
From: |
Alberto Garcia |
Subject: |
[Qemu-block] [PATCH 0/2] Don't allow snapshots if the overlay has parent nodes |
Date: |
Thu, 29 Oct 2015 15:00:47 +0200 |
There are several sanity checks for the 'blockdev-snapshot' command,
but none covers the use of a file BDS as the overlay node.
{ 'execute': 'blockdev-add', 'arguments':
{ 'options': { 'driver': 'qcow2',
'node-name': 'new0',
'file': { 'driver': 'file',
'filename': 'new.qcow2',
'node-name': 'file0' } } } }
{ 'execute': 'blockdev-snapshot', 'arguments':
{ 'node': 'virtio0',
'overlay': 'file0' } }
This series fixes that and adds a new test case. This of course
depends on the 'blockdev-snapshot' series:
https://lists.gnu.org/archive/html/qemu-block/2015-10/msg00974.html
I anyway wonder if it wouldn't be a good idea to have regular op
blockers in all file BDSs?
Regards,
Berto
Alberto Garcia (2):
block: Don't allow snapshots if the overlay has parent nodes
block: test 'blockdev-snapshot' using a file BDS as the overlay
blockdev.c | 5 +++++
tests/qemu-iotests/085 | 12 +++++++++++-
tests/qemu-iotests/085.out | 4 ++++
3 files changed, 20 insertions(+), 1 deletion(-)
--
2.6.1
- [Qemu-block] [PATCH 0/2] Don't allow snapshots if the overlay has parent nodes,
Alberto Garcia <=