[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl |
Date: |
Wed, 28 Oct 2015 10:51:34 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben:
> iscsi_ioctl emulates SG_GET_VERSION_NUM and SG_GET_SCSI_ID. Now that
> bdrv_ioctl() will be emulated with .bdrv_aio_ioctl, replicate the logic
> into iscsi_aio_ioctl to make them consistent.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/iscsi.c | 39 +++++++++++++++++++++++++++++++++++++--
> 1 file changed, 37 insertions(+), 2 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 93f1ee4..94cbdf2 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -96,6 +96,7 @@ typedef struct IscsiAIOCB {
> int status;
> int64_t sector_num;
> int nb_sectors;
> + int ret;
> #ifdef __linux__
> sg_io_hdr_t *ioh;
> #endif
> @@ -726,6 +727,37 @@ iscsi_aio_ioctl_cb(struct iscsi_context *iscsi, int
> status,
> iscsi_schedule_bh(acb);
> }
>
> +static void iscsi_ioctl_bh_completion(void *opaque)
> +{
> + IscsiAIOCB *acb = opaque;
> +
> + qemu_bh_delete(acb->bh);
> + acb->common.cb(acb->common.opaque, acb->ret);
> +}
qemu_aio_unref(acb)?
Kevin
- [Qemu-block] [PATCH 0/9] block: Fixes for bdrv_drain, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 1/9] block: Add more types for tracked request, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 2/9] block: Track flush requests, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 3/9] block: Track discard requests, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl, Fam Zheng, 2015/10/26
- Re: [Qemu-block] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl,
Kevin Wolf <=
- [Qemu-block] [PATCH 5/9] block: Add ioctl parameter fields to BlockRequest, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 7/9] block: Drop BlockDriver.bdrv_ioctl, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 8/9] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/26
- [Qemu-block] [PATCH 9/9] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/26
- Re: [Qemu-block] [PATCH 0/9] block: Fixes for bdrv_drain, Kevin Wolf, 2015/10/28