Re: [Qemu-block] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree

[Kevin Wolf]

Am 12.10.2015 um 22:00 hat Max Reitz geschrieben:
> Most of the options which blockdev_init() parses for both the
> BlockBackend and the root BDS are valid for just the root BDS as well
> (e.g. read-only). This patch allows specifying these options even if not
> creating a BlockBackend.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  blockdev.c | 160 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 154 insertions(+), 6 deletions(-)

> +
> +    /* disk I/O throttling */
> +    if (throttle_enabled(&cfg)) {
> +        if (!throttling_group) {
> +            throttling_group = bdrv_get_node_name(bs);
> +        }
> +        bdrv_io_limits_enable(bs, throttling_group);
> +        bdrv_set_io_limits(bs, &cfg);
> +    }

A while ago we discussed that we want to move throttling to the BB level
eventually. In that case, it might be wiser not to expose it for non-BB
nodes now.

Otherwise the patch looks good to me.

Kevin