[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v6 26/39] blockdev: Allow more options for BB-le
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree |
Date: |
Thu, 15 Oct 2015 13:29:45 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 12.10.2015 um 22:00 hat Max Reitz geschrieben:
> Most of the options which blockdev_init() parses for both the
> BlockBackend and the root BDS are valid for just the root BDS as well
> (e.g. read-only). This patch allows specifying these options even if not
> creating a BlockBackend.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 160
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 154 insertions(+), 6 deletions(-)
> +
> + /* disk I/O throttling */
> + if (throttle_enabled(&cfg)) {
> + if (!throttling_group) {
> + throttling_group = bdrv_get_node_name(bs);
> + }
> + bdrv_io_limits_enable(bs, throttling_group);
> + bdrv_set_io_limits(bs, &cfg);
> + }
A while ago we discussed that we want to move throttling to the BB level
eventually. In that case, it might be wiser not to expose it for non-BB
nodes now.
Otherwise the patch looks good to me.
Kevin
- [Qemu-block] [PATCH v6 24/39] blockdev: Do not create BDS for empty drive, (continued)
- [Qemu-block] [PATCH v6 24/39] blockdev: Do not create BDS for empty drive, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 23/39] block: Prepare for NULL BDS, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 25/39] blockdev: Pull out blockdev option extraction, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/10/12
- Re: [Qemu-block] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree,
Kevin Wolf <=
- [Qemu-block] [PATCH v6 29/39] blockdev: Add blockdev-close-tray, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 32/39] blockdev: Implement eject with basic operations, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 30/39] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 34/39] block: Inquire tray state before tray-moved events, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 33/39] blockdev: Implement change with basic operations, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 35/39] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 36/39] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 37/39] blockdev: read-only-mode for blockdev-change-medium, Max Reitz, 2015/10/12
- [Qemu-block] [PATCH v6 38/39] hmp: Add read-only-mode option to change command, Max Reitz, 2015/10/12