[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 11/12] qed: Implement .bdrv_drain
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v2 11/12] qed: Implement .bdrv_drain |
|
Date: |
Mon, 12 Oct 2015 16:23:09 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 12.10.2015 um 13:50 hat Fam Zheng geschrieben:
> The "need_check_timer" is used to clear the "NEED_CHECK" flag in the
> image header after a grace period once metadata update has finished. In
> compliance to the bdrv_drain semantics we should make sure it remains
> deleted once .bdrv_drain is called.
>
> Call the qed_need_check_timer_cb manually to update the header
> immediately.
>
> Signed-off-by: Fam Zheng <address@hidden>
What happens if a new allocating write request is issued during the
drained section and the timer gets reenabled?
Kevin
> block/qed.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/block/qed.c b/block/qed.c
> index a7ff1d9..23bd273 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -381,6 +381,12 @@ static void bdrv_qed_attach_aio_context(BlockDriverState
> *bs,
> }
> }
>
> +static void bdrv_qed_drain(BlockDriverState *bs)
> +{
> + qed_cancel_need_check_timer(bs->opaque);
> + qed_need_check_timer_cb(bs->opaque);
> +}
> +
> static int bdrv_qed_open(BlockDriverState *bs, QDict *options, int flags,
> Error **errp)
> {
> @@ -1683,6 +1689,7 @@ static BlockDriver bdrv_qed = {
> .bdrv_check = bdrv_qed_check,
> .bdrv_detach_aio_context = bdrv_qed_detach_aio_context,
> .bdrv_attach_aio_context = bdrv_qed_attach_aio_context,
> + .bdrv_drain = bdrv_qed_drain,
> };
>
> static void bdrv_qed_init(void)
> --
> 2.6.1
>
- [Qemu-block] [PATCH v2 04/12] aio: introduce aio_{disable, enable}_external, (continued)
[Qemu-block] [PATCH v2 08/12] block: Add "drained begin/end" for transactional blockdev-backup, Fam Zheng, 2015/10/12
[Qemu-block] [PATCH v2 07/12] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/12
[Qemu-block] [PATCH v2 11/12] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/12
- Re: [Qemu-block] [PATCH v2 11/12] qed: Implement .bdrv_drain,
Kevin Wolf <=
[Qemu-block] [PATCH v2 10/12] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/12
[Qemu-block] [PATCH v2 12/12] tests: Add test case for aio_disable_external, Fam Zheng, 2015/10/12
[Qemu-block] [PATCH v2 01/12] aio: Add "is_external" flag for event handlers, Fam Zheng, 2015/10/15
[Qemu-block] [PATCH v2 02/12] nbd: Mark fd handlers client type as "external", Fam Zheng, 2015/10/15
[Qemu-block] [PATCH v2 06/12] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/15
[Qemu-block] [PATCH v2 09/12] block: Add "drained begin/end" for internal snapshot, Fam Zheng, 2015/10/15