[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 03/38] blockdev: Allow creation of BDS trees
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 03/38] blockdev: Allow creation of BDS trees without BB |
Date: |
Fri, 18 Sep 2015 09:34:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/18/2015 09:22 AM, Max Reitz wrote:
> If the "id" field is missing from the options given to blockdev-add,
> just omit the BlockBackend and create the BlockDriverState tree alone.
>
> However, if "id" is missing, "node-name" must be specified; otherwise,
> the BDS tree would no longer be accessible.
>
> Many BDS options which are not parsed by bdrv_open() (like caching)
> cannot be specified for these BB-less BDS trees yet. A future patch will
> remove this limitation.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 44 +++++++++++++++++++++++++++++++-------------
> qapi/block-core.json | 13 +++++++++----
> tests/qemu-iotests/087 | 2 +-
> tests/qemu-iotests/087.out | 4 ++--
> 4 files changed, 43 insertions(+), 20 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 00/38] blockdev: BlockBackend and media, Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 01/38] block: Remove host floppy support, Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 02/38] block: Set BDRV_O_INCOMING in bdrv_fill_options(), Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 03/38] blockdev: Allow creation of BDS trees without BB, Max Reitz, 2015/09/18
- Re: [Qemu-block] [PATCH v5 03/38] blockdev: Allow creation of BDS trees without BB,
Eric Blake <=
- [Qemu-block] [PATCH v5 05/38] block: Make bdrv_is_inserted() return a bool, Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 06/38] block: Add blk_is_available(), Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 04/38] iotests: Only create BB if necessary, Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 07/38] block: Make bdrv_is_inserted() recursive, Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 09/38] block: Invoke change media CB before NULLing drv, Max Reitz, 2015/09/18
- [Qemu-block] [PATCH v5 08/38] block/raw_bsd: Drop raw_is_inserted(), Max Reitz, 2015/09/18