[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests |
Date: |
Fri, 4 Sep 2015 21:52:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 04.09.2015 19:18, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/137 | 143
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/137.out | 43 ++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 187 insertions(+)
> create mode 100755 tests/qemu-iotests/137
> create mode 100644 tests/qemu-iotests/137.out
>
> diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137
> new file mode 100755
> index 0000000..ad52f71
> --- /dev/null
> +++ b/tests/qemu-iotests/137
[snip]
> +echo
> +echo === Try setting some invalid values ===
> +echo
> +
> +$QEMU_IO \
> + -c "reopen -o lazy-refcounts=42" \
> + -c "reopen -o cache-size=1M,l2-cache-size=64k,refcount-cache-size=64k" \
> + -c "reopen -o cache-size=1M,l2-cache-size=2M" \
> + -c "reopen -o cache-size=1M,refcount-cache-size=2M" \
> + -c "reopen -o l2-cache-size=256T" \
> + -c "reopen -o l2-cache-size=64G" \
Testing this seems risky. The rest looks fine, but I'm not sure whether
this is really needed so much that we should risk the test failing on
some machines, especially in the future.
Or actually even on my machine:
$ touch ~/tmp/swap
$ truncate ~/tmp/swap --size 128G
$ fallocate -l 128G ~/tmp/swap
# mkswap ~maxx/tmp/swap
# swapon ~max/tmp/swap
$ cd /to/qemu/build
$ ./qemu-io -c 'reopen -o l2-cache-size=64G' test.qcow2
$
(Running the test itself is apparently a bad idea, because then for some
reason Linux thinks I actually want to use the swap and everything slows
down to a crawl)
Max
> + -c "reopen -o refcount-cache-size=256T" \
> + -c "reopen -o refcount-cache-size=64G" \
> + -c "reopen -o overlap-check=constant,overlap-check.template=all" \
> + -c "reopen -o overlap-check=blubb" \
> + -c "reopen -o overlap-check.template=blubb" \
> + "$TEST_IMG" | _filter_qemu_io
> +
[snip]
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 05/13] qcow2: Factor out qcow2_update_options(), (continued)
- [Qemu-block] [PATCH v2 05/13] qcow2: Factor out qcow2_update_options(), Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 07/13] qcow2: Move rest of option handling to qcow2_update_options(), Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 08/13] qcow2: Leave s unchanged on qcow2_update_options() failure, Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 09/13] qcow2: Fix memory leak in qcow2_update_options() error path, Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 10/13] qcow2: Make qcow2_update_options() suitable for transactions, Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change, Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 11/13] qcow2: Support updating driver-specific options in reopen, Kevin Wolf, 2015/09/04
- [Qemu-block] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests, Kevin Wolf, 2015/09/04
- Re: [Qemu-block] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests,
Max Reitz <=