[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/4] iotests: Do not suppress segfaults in ba
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 3/4] iotests: Do not suppress segfaults in bash tests |
Date: |
Wed, 2 Sep 2015 14:02:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 09/02/2015 12:52 PM, Max Reitz wrote:
> Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a
> segmentation fault, that message is invisible in most cases since the
> output is generally filtered and bash suppresses the segmentation fault
> notice for any but the last element of a pipe.
>
> Most of the time, the test will then fail anyway because of missing
> output, but not necessarily (as happened with test 82 recently).
>
> Fix this by making the corresponding environment variables point to
> wrapper functions which execute the respective command in a subshell.
>
> Giving options to qemu/qemu-io/qemu-img and path names with spaces were
> broken for the Python tests; this patch "accidentally" fixes that.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 0/4] iotests: Emit signal-kill messages, Max Reitz, 2015/09/02
- [Qemu-block] [PATCH v2 1/4] iotests: More options for VM.add_drive(), Max Reitz, 2015/09/02
- [Qemu-block] [PATCH v2 2/4] iotests: Respect -nodefaults in tests 41 and 55, Max Reitz, 2015/09/02
- [Qemu-block] [PATCH v2 3/4] iotests: Do not suppress segfaults in bash tests, Max Reitz, 2015/09/02
- Re: [Qemu-block] [PATCH v2 3/4] iotests: Do not suppress segfaults in bash tests,
Eric Blake <=
- [Qemu-block] [PATCH v2 4/4] iotests: Warn if python subprocess is killed, Max Reitz, 2015/09/02
- Re: [Qemu-block] [PATCH v2 0/4] iotests: Emit signal-kill messages, Kevin Wolf, 2015/09/03