[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/2] util - add automated ID generation utili
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH v2 1/2] util - add automated ID generation utility |
|
Date: |
Wed, 02 Sep 2015 08:35:37 +0200 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Wed 02 Sep 2015 12:30:15 AM CEST, Jeff Cody <address@hidden> wrote:
> Multiple sub-systems in QEMU may find it useful to generate IDs
> for objects that a user may reference via QMP or HMP. This patch
> presents a standardized way to do it, so that automatic ID generation
> follows the same rules.
> +
> +typedef enum IdSubSystems {
> + ID_QDEV,
> + ID_BLOCK,
> + ID_MAX /* last element, used as array size */
> +} IdSubSystems;
> +
> +char *id_generate(IdSubSystems);
Not that it matters much, but it seems that everywhere else in the QEMU
source code the rule is to name the parameters in function prototypes.
Otherwise, the patch looks good!
Reviewed-by: Alberto Garcia <address@hidden>
Berto