[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 1/4] ahci: remove dead reset code
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH 1/4] ahci: remove dead reset code |
Date: |
Tue, 1 Sep 2015 16:50:38 -0400 |
This check is dead due to an earlier conditional.
AHCI does not currently support hotplugging, so
checks to see if devices are present or not are useless.
Remove it.
Reported-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 48749c1..d04a161 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -604,10 +604,7 @@ static void ahci_reset_port(AHCIState *s, int port)
}
s->dev[port].port_state = STATE_RUN;
- if (!ide_state->blk) {
- pr->sig = 0;
- ide_state->status = SEEK_STAT | WRERR_STAT;
- } else if (ide_state->drive_kind == IDE_CD) {
+ if (ide_state->drive_kind == IDE_CD) {
pr->sig = SATA_SIGNATURE_CDROM;
ide_state->lcyl = 0x14;
ide_state->hcyl = 0xeb;
--
2.4.3
- [Qemu-block] [PATCH 0/4] ahci: clean up signature generation, John Snow, 2015/09/01
- [Qemu-block] [PATCH 2/4] ahci: fix signature generation, John Snow, 2015/09/01
- [Qemu-block] [PATCH 1/4] ahci: remove dead reset code,
John Snow <=
- [Qemu-block] [PATCH 3/4] ahci: remove cmd_fis argument from write_fis_d2h, John Snow, 2015/09/01
- [Qemu-block] [PATCH 4/4] ahci: clean up initial d2h semantics, John Snow, 2015/09/01
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation, John Snow, 2015/09/16
- Re: [Qemu-block] [PATCH 0/4] ahci: clean up signature generation, Stefan Hajnoczi, 2015/09/17