[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/6] block: Avoid BlockDriverSta
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/6] block: Avoid BlockDriverState.filename |
|
Date: |
Mon, 31 Aug 2015 14:53:00 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/18/2015 05:10 PM, Max Reitz wrote:
> In places which directly pass a filename to the OS, we should not use
> the filename field at all but exact_filename instead (although the
> former currently equals the latter if that is set).
>
> In raw_open_common(), we do not need to access BDS.filename because we
> already have a local variable pointing to the filename.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 5 +++--
> block/gluster.c | 2 +-
> block/raw-posix.c | 12 ++++++------
> block/raw-win32.c | 4 ++--
> 4 files changed, 12 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 0/6] block: Drop BDS.filename, Max Reitz, 2015/08/18
- [Qemu-block] [PATCH v4 1/6] block: Change bdrv_get_encrypted_filename(), Max Reitz, 2015/08/18
- [Qemu-block] [PATCH v4 2/6] block: Avoid BlockDriverState.filename, Max Reitz, 2015/08/18
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/6] block: Avoid BlockDriverState.filename,
Eric Blake <=
- [Qemu-block] [PATCH v4 3/6] block: Add bdrv_filename(), Max Reitz, 2015/08/18
- [Qemu-block] [PATCH v4 4/6] qemu-img: Use bdrv_filename_alloc() for map, Max Reitz, 2015/08/18
- [Qemu-block] [PATCH v4 6/6] iotests: Test changed Quorum filename, Max Reitz, 2015/08/18
- [Qemu-block] [PATCH v4 5/6] block: Drop BlockDriverState.filename, Max Reitz, 2015/08/18