[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL for-2.4 2/5] blockdev: no need to drain in qmp_block_
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PULL for-2.4 2/5] blockdev: no need to drain in qmp_block_commit |
Date: |
Tue, 14 Jul 2015 22:26:54 -0400 |
From: Paolo Bonzini <address@hidden>
Draining is not necessary, I/O can happen as soon as the
commit coroutine yields. Draining can be necessary before
reopening the file for read/write, or while modifying the
backing file chain, but that is done separately in
bdrv_reopen_multiple or bdrv_close; this particular
bdrv_drain_all does nothing for that.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>
---
blockdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 7fee519..50421c8 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2380,9 +2380,6 @@ void qmp_block_commit(const char *device,
aio_context = bdrv_get_aio_context(bs);
aio_context_acquire(aio_context);
- /* drain all i/o before commits */
- bdrv_drain_all();
-
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, errp)) {
goto out;
}
--
1.9.3
- [Qemu-block] [PULL for-2.4 0/5] Block layer patches for 2.4.0-rc1, Jeff Cody, 2015/07/14
- [Qemu-block] [PULL for-2.4 1/5] block/mirror: Sleep periodically during bitmap scanning, Jeff Cody, 2015/07/14
- [Qemu-block] [PULL for-2.4 2/5] blockdev: no need to drain in qmp_block_commit,
Jeff Cody <=
- [Qemu-block] [PULL for-2.4 3/5] block: keep bitmap if incremental backup job is cancelled, Jeff Cody, 2015/07/14
- [Qemu-block] [PULL for-2.4 4/5] mirror: correct buf_size, Jeff Cody, 2015/07/14
- [Qemu-block] [PULL for-2.4 5/5] block/curl: Don't lose original error when a connection fails., Jeff Cody, 2015/07/14
- Re: [Qemu-block] [Qemu-devel] [PULL for-2.4 0/5] Block layer patches for 2.4.0-rc1, Peter Maydell, 2015/07/15