[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors |
Date: |
Thu, 25 Jun 2015 18:45:38 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 06/25 09:02, Fam Zheng wrote:
> On Wed, 06/24 19:01, Paolo Bonzini wrote:
> >
> >
> > On 24/06/2015 11:08, Fam Zheng wrote:
> > >> Stefan,
> > >>
> > >> The only controversial patches are the qmp/drive-mirror ones (1-3), while
> > >> patches 4-8 are still useful on their own: they fix the mentioned crash
> > >> and
> > >> improve iotests.
> > >>
> > >> Shall we merge the second half (of course none of them depend on 1-3)
> > >> now that
> > >> softfreeze is approaching?
> > >
> > > Stefan, would you consider applying patches 4-8?
> >
> > Actually why not apply all of them? Even if blockdev-mirror is a
> > superior interface in the long run, the current behavior of drive-mirror
> > can cause images to balloon up to the full size, which is bad.
> > Extending drive-mirror is okay IMHO for 2.4.
> >
>
> Before we do that, Andrey Korolyov has reported a hang issue with unmap=true,
> I'll take a look at it today.
There is no problem, the observasion by Andrey was just that qmp command takes
a few minutes before returning, because he didn't apply
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg02511.html
Fam
- [Qemu-block] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard, (continued)
- [Qemu-block] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 5/8] block: Remove bdrv_reset_dirty, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 6/8] qemu-iotests: Make block job methods common, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 7/8] qemu-iotests: Add test case for mirror with unmap, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 8/8] iotests: Use event_wait in wait_ready, Fam Zheng, 2015/06/08
- Re: [Qemu-block] [PATCH v7 0/8] block: Mirror discarded sectors, Stefan Hajnoczi, 2015/06/08
- Re: [Qemu-block] [PATCH v7 0/8] block: Mirror discarded sectors, Fam Zheng, 2015/06/11
- Re: [Qemu-block] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors, Fam Zheng, 2015/06/24
- Re: [Qemu-block] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors, Paolo Bonzini, 2015/06/24
- Re: [Qemu-block] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors, Fam Zheng, 2015/06/24
- Re: [Qemu-block] [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors,
Fam Zheng <=
- Re: [Qemu-block] [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors, Alexandre DERUMIER, 2015/06/26
- Re: [Qemu-block] [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors, Alexandre DERUMIER, 2015/06/26
- Re: [Qemu-block] [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors, Fam Zheng, 2015/06/28
Re: [Qemu-block] [PATCH v7 0/8] block: Mirror discarded sectors, Stefan Hajnoczi, 2015/06/26