[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] blockdev: no need to drain in qmp_block_commit
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH] blockdev: no need to drain in qmp_block_commit |
|
Date: |
Fri, 29 May 2015 13:43:29 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, May 28, 2015 at 04:21:43PM +0200, Paolo Bonzini wrote:
> Draining is not necessary, I/O can happen as soon as the
> commit coroutine yields. Draining can be necessary before
> reopening the file for read/write, or while modifying the
> backing file chain, but that is done separately in
> bdrv_reopen_multiple or bdrv_close; this particular
> bdrv_drain_all does nothing for that.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockdev.c | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgp07Yf2pr6dY.pgp
Description: PGP signature