Re: [Qemu-block] [PATCH 29/34] qemu-iotests: Remove cache mode test without medium

[Max Reitz]

On 08.05.2015 19:22, Kevin Wolf wrote:
> Specifying the cache mode for a driver without a medium is not a useful
> thing to do: As long as there is no medium, the cache mode doesn't make
> a difference, and once the 'change' command is used to insert a medium,
> it ignores the old cache mode and makes the new medium use
> cache=writethrough.
>
> Later patches will make it an error to specify the cache mode for an
> empty drive. Remove the corresponding test case.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   tests/qemu-iotests/051     | 14 --------------
>   tests/qemu-iotests/051.out | 26 --------------------------
>   2 files changed, 40 deletions(-)

Well, you could have changed it to format=null-co or something...

But it's your test so it's your call whether to remove it or not.

Reviewed-by: Max Reitz <address@hidden>