[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO
From: |
Wen Congyang |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction |
Date: |
Wed, 13 May 2015 19:22:33 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/14/2015 01:28 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> blockdev.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index ae52d27..bd28183 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1649,6 +1649,7 @@ typedef struct BlockdevBackupState {
> BlockDriverState *bs;
> BlockJob *job;
> AioContext *aio_context;
> + Error *blocker;
> } BlockdevBackupState;
>
> static void blockdev_backup_prepare(BlkTransactionState *common, Error
> **errp)
> @@ -1685,6 +1686,10 @@ static void
> blockdev_backup_prepare(BlkTransactionState *common, Error **errp)
> }
> aio_context_acquire(state->aio_context);
>
> + state->bs = bs;
> + error_setg(&state->blocker, "blockdev-backup in progress");
> + bdrv_op_block(bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker);
> +
Do you test this patch? You need to read from bs to do backup!!
If the mode is none, you also need to write to bs!!
Thanks
Wen Congyang
> qmp_blockdev_backup(backup->device, backup->target,
> backup->sync,
> backup->has_speed, backup->speed,
> @@ -1696,7 +1701,6 @@ static void blockdev_backup_prepare(BlkTransactionState
> *common, Error **errp)
> return;
> }
>
> - state->bs = bs;
> state->job = state->bs->job;
> }
>
> @@ -1715,6 +1719,10 @@ static void blockdev_backup_clean(BlkTransactionState
> *common)
> {
> BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common,
> common);
>
> + if (state->bs) {
> + bdrv_op_unblock(state->bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker);
> + error_free(state->blocker);
> + }
> if (state->aio_context) {
> aio_context_release(state->aio_context);
> }
>
- [Qemu-block] [PATCH v2 02/11] block: Add op blocker notifier list, (continued)
- [Qemu-block] [PATCH v2 02/11] block: Add op blocker notifier list, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 04/11] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 07/11] blockdev: Block device IO during internal snapshot transaction, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 06/11] nbd-server: Clear "can_read" when "device io" blocker is set, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 08/11] blockdev: Block device IO during external snapshot transaction, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 09/11] blockdev: Block device IO during drive-backup transaction, Fam Zheng, 2015/05/13
- [Qemu-block] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, Fam Zheng, 2015/05/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction,
Wen Congyang <=
- Re: [Qemu-block] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, Paolo Bonzini, 2015/05/13
[Qemu-block] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/13