[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required |
Date: |
Tue, 12 May 2015 12:32:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
> The qemu-io tool does not check if the image is encrypted so
> historically would silently corrupt the sectors by writing
> plain text data into them instead of cipher text. The earlier
> commit turns this mistake into a fatal abort, so check for
> encryption and prompt for key when required.
Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3
patches? Should this be rearranged so that 1/5 comes after this to
avoid triggering the abort?
>
> This enables us to add unit tests to ensure we don't break
> the ability of qemu-img to convert existing encrypted qcow2
> files into a non-encrypted format.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> qemu-io.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 3/5] util: allow \n to terminate password input, (continued)
[Qemu-block] [PATCH 4/5] qemu-io: prompt for encryption keys when required, Daniel P. Berrange, 2015/05/12
- Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required,
Eric Blake <=
[Qemu-block] [PATCH 2/5] util: move read_password method out of qemu-img into osdep/oslib, Daniel P. Berrange, 2015/05/12
Re: [Qemu-block] [PATCH 0/5] Misc fixes and testing of qcow[2] encryption, Kevin Wolf, 2015/05/18