[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.3 v2] qcow2: Fix header update with overri
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file |
Date: |
Wed, 8 Apr 2015 10:30:13 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Apr 07, 2015 at 03:03:16PM +0200, Kevin Wolf wrote:
> In recent qemu versions, it is possible to override the backing file
> name and format that is stored in the image file with values given at
> runtime. In such cases, the temporary override could end up in the
> image header if the qcow2 header was updated, while obviously correct
> behaviour would be to leave the on-disk backing file path/format
> unchanged.
>
> Fix this and add a test case for it.
>
> Reported-by: Michael Tokarev <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> v2:
> - Now freeing instead of leaking the new strings in qcow2_close()
>
> block/qcow2.c | 29 ++++++++++----
> block/qcow2.h | 6 +++
> tests/qemu-iotests/130 | 95
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/130.out | 43 +++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 5 files changed, 167 insertions(+), 7 deletions(-)
> create mode 100755 tests/qemu-iotests/130
> create mode 100644 tests/qemu-iotests/130.out
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpnOCTaPeWp8.pgp
Description: PGP signature