[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block dr
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication |
Date: |
Wed, 25 Mar 2015 09:43:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/25/2015 06:48 AM, Paolo Bonzini wrote:
>> ##
>> +# @COLOMode
>> +#
>> +# An enumeration of COLO mode.
s/mode/modes/
>> +#
>> +# @unprotected: COLO is not started or after failover
>> +#
>> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU.
Inconsistent on whether you end with '.'
>> +#
>> +# @secondary: Secondary mode, receive the vm's state from primary QEMU.
>> +#
>> +# Since: 2.4
>> +##
>> +{ 'enum' : 'COLOMode',
>> + 'data' : ['unprotected', 'primary', 'secondary']}
>
> Perhaps replace COLOMode with ReplicationMode or FaultToleranceMode?
If you keep the name COLOMode, it would also be nice to spell out
'COurse-grain LOck-stepping' at least once somewhere in the .json file
(probably in the description of this enum). A name like ReplicationMode
is a bit more self-documenting (I know what replication is, I have to
look up what COLO is).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors, (continued)
- [Qemu-block] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 03/13] NBD client: connect to nbd server later, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 05/13] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/03/25