[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] hw/pci-host/designware: Declare CPU QOM types using DEFI
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 1/8] hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro |
|
Date: |
Tue, 17 Oct 2023 17:31:02 +0100 |
On Thu, 12 Oct 2023 at 13:19, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> When multiple QOM types are registered in the same file,
> it is simpler to use the the DEFINE_TYPES() macro. In
> particular because type array declared with such macro
> are easier to review.
>
> Remove a pointless structure declaration in "designware.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 0/8] hw/pci-host/designware: QOM shuffling (Host bridge <-> Root function), Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 1/8] hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro, Philippe Mathieu-Daudé, 2023/10/12
- Re: [PATCH 1/8] hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro,
Peter Maydell <=
- [PATCH 2/8] hw/pci-host/designware: Initialize root function in host bridge realize, Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 3/8] hw/pci-host/designware: Add 'host_mem' variable for clarity, Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 4/8] hw/pci-host/designware: Hoist host controller in root function #0, Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 5/8] hw/pci-host/designware: Keep host reference in DesignwarePCIEViewport, Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 6/8] hw/pci-host/designware: Move viewports from root func to host bridge, Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 7/8] hw/pci-host/designware: Move MSI registers from root func to host bridge, Philippe Mathieu-Daudé, 2023/10/12
- [PATCH 8/8] hw/pci-host/designware: Create ViewPorts during host bridge realization, Philippe Mathieu-Daudé, 2023/10/12
- Re: [PATCH 0/8] hw/pci-host/designware: QOM shuffling (Host bridge <-> Root function), Peter Maydell, 2023/10/27