qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/10] tests/npcm7xx_adc: Clean up global variable shadowing


From: Thomas Huth
Subject: Re: [PATCH 07/10] tests/npcm7xx_adc: Clean up global variable shadowing
Date: Fri, 13 Oct 2023 08:15:29 +0200
User-agent: Mozilla Thunderbird

On 09/10/2023 12.02, Philippe Mathieu-Daudé wrote:
Rename the global 'adc' variable in order to avoid:

   tests/qtest/npcm7xx_adc-test.c:98:58: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static uint32_t adc_read_con(QTestState *qts, const ADC *adc)
                                                            ^
   tests/qtest/npcm7xx_adc-test.c:103:55: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_write_con(QTestState *qts, const ADC *adc, uint32_t value)
                                                         ^
   tests/qtest/npcm7xx_adc-test.c:108:59: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static uint32_t adc_read_data(QTestState *qts, const ADC *adc)
                                                             ^
   tests/qtest/npcm7xx_adc-test.c:119:53: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_qom_set(QTestState *qts, const ADC *adc,
                                                       ^
   tests/qtest/npcm7xx_adc-test.c:135:57: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_write_input(QTestState *qts, const ADC *adc,
                                                           ^
   tests/qtest/npcm7xx_adc-test.c:144:56: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_write_vref(QTestState *qts, const ADC *adc, uint32_t value)
                                                          ^
   tests/qtest/npcm7xx_adc-test.c:162:59: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static uint32_t adc_prescaler(QTestState *qts, const ADC *adc)
                                                             ^
   tests/qtest/npcm7xx_adc-test.c:175:64: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_wait_conv_finished(QTestState *qts, const ADC *adc,
                                                                  ^
   tests/qtest/npcm7xx_adc-test.c:196:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
     const ADC *adc = adc_p;
                ^
   tests/qtest/npcm7xx_adc-test.c:207:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
     const ADC *adc = adc_p;
                ^
   tests/qtest/npcm7xx_adc-test.c:235:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
     const ADC *adc = adc_p;
                ^
   tests/qtest/npcm7xx_adc-test.c:267:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
     const ADC *adc = adc_p;
                ^
   tests/qtest/npcm7xx_adc-test.c:293:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
     const ADC *adc = adc_p;
                ^
   tests/qtest/npcm7xx_adc-test.c:311:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
     const ADC *adc = adc_p;
                ^
   tests/qtest/npcm7xx_adc-test.c:93:5: note: previous declaration is here
   ADC adc = {
       ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  tests/qtest/npcm7xx_adc-test.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]