Re: [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test

[Chris Rauer]

Ack.  will send out v2.

On Wed, Sep 27, 2023 at 9:44 PM Thomas Huth <thuth@redhat.com> wrote:

On 28/09/2023 05.45, Chris Rauer wrote:

Could you please add a proper patch description how this is fixing the issue?

  Thanks,
   Thomas


> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897
> Signed-off-by: Chris Rauer <crauer@google.com>
> ---
>   tests/qtest/npcm7xx_timer-test.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c
> index 43711049ca..58f58c2f71 100644
> --- a/tests/qtest/npcm7xx_timer-test.c
> +++ b/tests/qtest/npcm7xx_timer-test.c
> @@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data)
>       int i;
>   
>       tim_reset(td);
> +    clock_step_next();
>   
>       tim_write_ticr(td, count);
>       tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));