qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/6] qtest: implement named interception of out-GPIO


From: Chris Laplante
Subject: Re: [PATCH v2 3/6] qtest: implement named interception of out-GPIO
Date: Thu, 27 Jul 2023 21:32:46 +0000

> (g_strcmp0() can handle the NULL case without having
> to special case it -- this is how qdev_get_named_gpio_list()
> finds entries in the ngl list.)
> 
> Apologies for not noticing that on the first round of review.

No worries - it makes the code much simpler anyway. Should we bother factoring 
out qtest_install_gpio_out_intercept still? It is only used in one place now, 
as before.

Thanks,
Chris



reply via email to

[Prev in Thread] Current Thread [Next in Thread]