[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 6/8] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init
From: |
Gavin Shan |
Subject: |
[PATCH v2 6/8] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init() |
Date: |
Wed, 26 Jul 2023 10:32:03 +1000 |
Set mc->valid_cpu_{types, models} so that the specified CPU type
can be checked in machine_run_board_init(). We needn't to do the
check by ourselves.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
hw/arm/sbsa-ref.c | 29 ++++++++++++-----------------
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index bc89eb4806..66d171b745 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -149,25 +149,23 @@ static const int sbsa_ref_irqmap[] = {
[SBSA_GWDT_WS0] = 16,
};
-static const char * const valid_cpus[] = {
+static const char * const valid_cpu_types[] = {
ARM_CPU_TYPE_NAME("cortex-a57"),
ARM_CPU_TYPE_NAME("cortex-a72"),
ARM_CPU_TYPE_NAME("neoverse-n1"),
ARM_CPU_TYPE_NAME("neoverse-v1"),
ARM_CPU_TYPE_NAME("max"),
+ NULL,
};
-static bool cpu_type_valid(const char *cpu)
-{
- int i;
-
- for (i = 0; i < ARRAY_SIZE(valid_cpus); i++) {
- if (strcmp(cpu, valid_cpus[i]) == 0) {
- return true;
- }
- }
- return false;
-}
+static const char * const valid_cpu_models[] = {
+ "cortex-a57",
+ "cortex-a72",
+ "neoverse-n1",
+ "neoverse-v1",
+ "max",
+ NULL,
+};
static uint64_t sbsa_ref_cpu_mp_affinity(SBSAMachineState *sms, int idx)
{
@@ -730,11 +728,6 @@ static void sbsa_ref_init(MachineState *machine)
const CPUArchIdList *possible_cpus;
int n, sbsa_max_cpus;
- if (!cpu_type_valid(machine->cpu_type)) {
- error_report("sbsa-ref: CPU type %s not supported", machine->cpu_type);
- exit(1);
- }
-
if (kvm_enabled()) {
error_report("sbsa-ref: KVM is not supported for this machine");
exit(1);
@@ -899,6 +892,8 @@ static void sbsa_ref_class_init(ObjectClass *oc, void *data)
mc->init = sbsa_ref_init;
mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
+ mc->valid_cpu_types = valid_cpu_types;
+ mc->valid_cpu_models = valid_cpu_models;
mc->max_cpus = 512;
mc->pci_allow_0_address = true;
mc->minimum_page_bits = 12;
--
2.41.0
- [PATCH v2 2/8] machine: Introduce helper is_cpu_type_supported(), (continued)
[PATCH v2 4/8] hw/arm/virt: Check CPU type in machine_run_board_init(), Gavin Shan, 2023/07/25
[PATCH v2 5/8] hw/arm/virt: Unsupported host CPU model on TCG, Gavin Shan, 2023/07/25
[PATCH v2 6/8] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init(),
Gavin Shan <=
[PATCH v2 7/8] hw/arm: Check CPU type in machine_run_board_init(), Gavin Shan, 2023/07/25
[PATCH v2 8/8] hw/riscv/shakti_c: Check CPU type in machine_run_board_init(), Gavin Shan, 2023/07/25