Re: [PATCH] Prepare bcm properties for videocore 4

[Kambalin, Sergey]

Hello!

Thank you guys for clarifications!

> Are the VC4 properties supposed to be present on
> all our existing raspi models? (i.e. is this a bug
> fix for our existing models rather than stuff we only
> want on the new raspi4b?)

Yes, they're needed to support RPI4 work. And I think cannot be considered as a bug fix.

So I'm going to send one patch to replace the magic values with named constants.

And then I'm going to spend some time to slice the entire rpi4 machine to series of small patches.

Am I understand it right that each patch in the set must pass all the tests?

---

От: Philippe Mathieu-Daudé <philmd@linaro.org>
Отправлено: 30 мая 2023 г. 17:02:00
Кому: Kambalin, Sergey; Peter Maydell; Sergey Kambalin
Копия: qemu-arm@nongnu.org; qemu-devel@nongnu.org
Тема: Re: [PATCH] Prepare bcm properties for videocore 4

 

On 30/5/23 15:00, Kambalin, Sergey wrote:
> Got it! Thanks!
>
> I'll split this one to three patches:
> 1) replace magic numbers with named constants (refactoring)
>
> 2) add new properties for VC 4
>
> 3) Add some unit tests to check the newly added properties via mailbox
>
>
> Is it OK?

This looks good. Try to imagine sitting on the other side, where
developers will review your code. Usually the simplest the better,
even dumb patches, since there is no risk for doubt. Don't be afraid
to post many small patches.

Personally I'd do:

- import Linux definitions
- replace current magic values with imported Linux defs
- add GET_CLOCKS property
- add GET_THROTTLED property
- add FRAMEBUFFER properties
- add GPIO properties
- add VCHIQ property

Look at do_test_arm_raspi*() in tests/avocado/boot_linux_console.py,
you could add newer kernels which use the properties you added.

> (Sorry for wasting your time by inappropriate patches - this is my first
> experience with OSS)

So far you are doing great!

Thanks,

Phil.