[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/10] hw/arm/realview: Use generic realview_common_machine_init(
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 09/10] hw/arm/realview: Use generic realview_common_machine_init() |
Date: |
Wed, 24 May 2023 16:59:05 +0200 |
The realview_board_type enum is now unused. Remove it and have
all instances use the common realview_common_machine_init()
method.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/realview.c | 46 ++--------------------------------------------
1 file changed, 2 insertions(+), 44 deletions(-)
diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index 917a1b22df..b7bb384000 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -54,13 +54,6 @@ static struct arm_boot_info realview_binfo = {
.smp_bootreg_addr = SMP_BOOTREG_ADDR,
};
-enum realview_board_type {
- BOARD_EB,
- BOARD_EB_MPCORE,
- BOARD_PB_A8,
- BOARD_PBX_A9,
-};
-
static void split_irq_from_named(DeviceState *src, const char* outname,
qemu_irq out1, qemu_irq out2) {
DeviceState *splitter = qdev_new(TYPE_SPLIT_IRQ);
@@ -75,8 +68,7 @@ static void split_irq_from_named(DeviceState *src, const
char* outname,
qdev_get_gpio_in(splitter, 0));
}
-static void realview_init(MachineState *machine,
- enum realview_board_type board_type)
+static void realview_common_machine_init(MachineState *machine)
{
RealviewMachineClass *rmc = REALVIEW_MACHINE_GET_CLASS(machine);
ARMCPU *cpu = NULL;
@@ -103,17 +95,6 @@ static void realview_init(MachineState *machine,
ram_addr_t low_ram_size;
ram_addr_t ram_size = machine->ram_size;
- switch (board_type) {
- case BOARD_EB:
- break;
- case BOARD_EB_MPCORE:
- break;
- case BOARD_PB_A8:
- break;
- case BOARD_PBX_A9:
- break;
- }
-
for (n = 0; n < smp_cpus; n++) {
Object *cpuobj = object_new(machine->cpu_type);
@@ -381,30 +362,11 @@ static void realview_init(MachineState *machine,
arm_load_kernel(ARM_CPU(first_cpu), machine, &realview_binfo);
}
-static void realview_eb_init(MachineState *machine)
-{
- realview_init(machine, BOARD_EB);
-}
-
-static void realview_eb_mpcore_init(MachineState *machine)
-{
- realview_init(machine, BOARD_EB_MPCORE);
-}
-
-static void realview_pb_a8_init(MachineState *machine)
-{
- realview_init(machine, BOARD_PB_A8);
-}
-
-static void realview_pbx_a9_init(MachineState *machine)
-{
- realview_init(machine, BOARD_PBX_A9);
-}
-
static void realview_common_class_init(ObjectClass *oc, void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
+ mc->init = realview_common_machine_init;
mc->ignore_memory_transaction_failures = true;
}
@@ -414,7 +376,6 @@ static void realview_eb_class_init(ObjectClass *oc, void
*data)
RealviewMachineClass *rmc = REALVIEW_MACHINE_CLASS(oc);
mc->desc = "ARM RealView Emulation Baseboard (ARM926EJ-S)";
- mc->init = realview_eb_init;
mc->block_default_type = IF_SCSI;
mc->default_cpu_type = ARM_CPU_TYPE_NAME("arm926");
rmc->board_id = 0x33b;
@@ -426,7 +387,6 @@ static void realview_eb_mpcore_class_init(ObjectClass *oc,
void *data)
RealviewMachineClass *rmc = REALVIEW_MACHINE_CLASS(oc);
mc->desc = "ARM RealView Emulation Baseboard (ARM11MPCore)";
- mc->init = realview_eb_mpcore_init;
mc->block_default_type = IF_SCSI;
mc->max_cpus = 4;
mc->default_cpu_type = ARM_CPU_TYPE_NAME("arm11mpcore");
@@ -440,7 +400,6 @@ static void realview_pb_a8_class_init(ObjectClass *oc, void
*data)
RealviewMachineClass *rmc = REALVIEW_MACHINE_CLASS(oc);
mc->desc = "ARM RealView Platform Baseboard for Cortex-A8";
- mc->init = realview_pb_a8_init;
mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a8");
rmc->board_id = 0x769;
rmc->is_pb = true;
@@ -453,7 +412,6 @@ static void realview_pbx_a9_class_init(ObjectClass *oc,
void *data)
RealviewMachineClass *rmc = REALVIEW_MACHINE_CLASS(oc);
mc->desc = "ARM RealView Platform Baseboard Explore for Cortex-A9";
- mc->init = realview_pbx_a9_init;
mc->max_cpus = 4;
mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a9");
rmc->board_id = 0x76d;
--
2.38.1
- Re: [PATCH 01/10] hw/arm/realview: Simplify using 'break' statement, (continued)
- [PATCH 05/10] hw/arm/realview: Move 'board_id' to RealviewMachineClass, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH 07/10] hw/arm/realview: Move 'mpcore_periphbase' to RealviewMachineClass, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH 06/10] hw/arm/realview: Move 'is_pb' to RealviewMachineClass, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH 08/10] hw/arm/realview: Move 'loader_start' to RealviewMachineClass, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH 09/10] hw/arm/realview: Use generic realview_common_machine_init(),
Philippe Mathieu-Daudé <=
- [PATCH 10/10] hw/arm/realview: Set MachineClass::default_nic in machine_class_init(), Philippe Mathieu-Daudé, 2023/05/24