Re: [PATCH 1/2] docs: sbsa: correct graphics card name

[Marcin Juszkiewicz]

W dniu 23.05.2023 o 19:11, Thomas Huth pisze:
> On 23/05/2023 17.56, Marcin Juszkiewicz wrote:
> > We moved from VGA to Bochs to have PCIe card.
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> > ---
> >   docs/system/arm/sbsa.rst | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/docs/system/arm/sbsa.rst b/docs/system/arm/sbsa.rst
> > index b499d7e927..fea4992df2 100644
> > --- a/docs/system/arm/sbsa.rst
> > +++ b/docs/system/arm/sbsa.rst
> > @@ -27,6 +27,6 @@ The sbsa-ref board supports:
> >     - System bus EHCI controller
> >     - CDROM and hard disc on AHCI bus
> >     - E1000E ethernet card on PCIe bus
> > -  - VGA display adaptor on PCIe bus
> > +  - Bochs display adaptor on PCIe bus
> >     - A generic SBSA watchdog device
>
> While you're at it, I'd suggest to replace "adaptor" with "adapter" 
> which seems to be way more common in the QEMU sources:
>
> $ grep -r adaptor * | wc -l
> 5
> $ grep -r adapter * | wc -l
> 385
>
> With that changed:
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks. changed.


> PS: An idea for another patch: I think the "config SBSA_REF" in 
> hw/arm/Kconfig should select BOCHS_DISPLAY now, since this board seems 
> to always require this card now 

Thanks, patch sent.

> (is there a reason why it can't be disabled with "-vga none" or "-nodefaults"?)

That's something I need to check how it should be done. Should it also 
drop default_nic?