[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 0/3] arm: Clean up and rename hw/arm/
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 0/3] arm: Clean up and rename hw/arm/arm.h to hw/arm/boot.h |
|
Date: |
Thu, 16 May 2019 20:18:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/16/19 6:38 PM, Peter Maydell wrote:
> The header hw/arm/arm.h used to be a general bucket for
> putting all kinds of arm-related declarations in. It now
> has mostly kernel-boot related declarations, with one
> exception: the declaration of the system_clock_scale global.
> This patchset:
> * moves system_clock_scale to armv7m_systick.h (since that
> is the only device that uses it)
> * deletes some unnecessary #includes of hw/arm/arm.h
> * renames it to hw/arm/boot.h, since it now only has
> declarations relating to hw/arm/boot.c functionality
Yay \o/
> Since system_clock_scale is a weird thing, I have included
> in the first patch an expansion of the comment describing
> it to be clearer about what it does, and also a TODO note
> sketching out how we could go about eradicating this global.
>
> thanks
> -- PMM
>
> Peter Maydell (3):
> arm: Move system_clock_scale to armv7m_systick.h
> arm: Remove unnecessary includes of hw/arm/arm.h
> arm: Rename hw/arm/arm.h to hw/arm/boot.h
Series:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>