[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 05/15] tests/tcg/minilib: support
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 05/15] tests/tcg/minilib: support %c format char |
Date: |
Wed, 1 May 2019 07:40:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/30/19 9:52 AM, Alex Bennée wrote:
> @@ -119,6 +119,10 @@ void ml_printf(const char *fmt, ...)
> str = va_arg(ap, char*);
> print_str(str);
> break;
> + case 'c':
> + c = (char) va_arg(ap, int);
> + __sys_outc(c);
> + break;
The assignment and cast are both unnecessary.
You could just as well write
__sys_outc(va_arg(ap, int))
but it's not wrong so
Reviewed-by: Richard Henderson <address@hidden>
r~
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-arm] [Qemu-devel] [PATCH v5 05/15] tests/tcg/minilib: support %c format char,
Richard Henderson <=