|
From: | Heyi Guo |
Subject: | Re: [Qemu-arm] [PATCH] hw/arm/acpi: enable SHPC native hot plug |
Date: | Mon, 4 Mar 2019 08:46:43 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 2019/3/4 7:38, Michael S. Tsirkin wrote:
On Fri, Mar 01, 2019 at 10:28:30AM +0800, Heyi Guo wrote:After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have SHPC controller on ARM, so just enalbe SHPC native hot plug. Cc: Shannon Zhao <address@hidden> Cc: Peter Maydell <address@hidden> Cc: "Michael S. Tsirkin" <address@hidden> Cc: Igor Mammedov <address@hidden> Signed-off-by: Heyi Guo <address@hidden> Signed-off-by: Heyi Guo <address@hidden>I don't think you need two Signed-off-by lines. Besides that: Reviewed-by: Michael S. Tsirkin <address@hidden> Pls feel free to merge through the ARM tree.
Thanks, I'll change that and add your R-b, and send a v2 for some dear maintainer to commit it :) Heyi
--- hw/arm/virt-acpi-build.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 04b62c7..7849ec5 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -265,7 +265,12 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap, aml_create_dword_field(aml_arg(3), aml_int(8), "CDW3")); aml_append(ifctx, aml_store(aml_name("CDW2"), aml_name("SUPP"))); aml_append(ifctx, aml_store(aml_name("CDW3"), aml_name("CTRL"))); - aml_append(ifctx, aml_store(aml_and(aml_name("CTRL"), aml_int(0x1D), NULL), + + /* + * Allow OS control for all 5 features: + * PCIeHotplug SHPCHotplug PME AER PCIeCapability. + */ + aml_append(ifctx, aml_store(aml_and(aml_name("CTRL"), aml_int(0x1F), NULL), aml_name("CTRL")));ifctx1 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(0x1))));-- 1.8.3.1.
[Prev in Thread] | Current Thread | [Next in Thread] |