Re: [Qemu-arm] [Qemu-devel] [PATCH 8/8] hw/arm/armsse: Unify init-svtor and cpuwait handling

[Richard Henderson]

On 2/19/19 4:58 AM, Peter Maydell wrote:
> At the moment the handling of init-svtor and cpuwait initial
> values is split between armsse.c and iotkit-sysctl.c:
> the code in armsse.c sets the initial state of the CPU
> object by setting the init-svtor and start-powered-off
> properties, but the iotkit-sysctl.c code has its own
> code setting the reset values of its registers (which are
> then used when updating the CPU when the guest makes
> runtime changes).
> 
> Clean this up by making the armsse.c code set properties on the
> iotkit-sysctl object to define the initial values of the
> registers, so they always match the initial CPU state,
> and update the comments in armsse.c accordingly.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  include/hw/misc/iotkit-sysctl.h |  3 ++
>  hw/arm/armsse.c                 | 49 +++++++++++++++++++++------------
>  hw/misc/iotkit-sysctl.c         | 20 ++++++--------
>  3 files changed, 42 insertions(+), 30 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~