[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 10/15] range: Remove Range from "qemu/typedefs.h"
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [PATCH 10/15] range: Remove Range from "qemu/typedefs.h" |
Date: |
Mon, 14 Jan 2019 11:30:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/14/19 9:56 AM, Thomas Huth wrote:
> On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote:
>> Range is only used in "hw/pci-host/q35.h" in the MCHPCIState, and
>> in "hw/pci/pci.h" by pci_bus_get_w64_range(). Let them include
>> "qemu/range.h" directly to simplify "qemu/typedefs.h".
>>
>> To clean "qemu/typedefs.h", move the declaration to "qemu/range.h"
>> (removing the forward declaration).
>
> Since Range seems to be meant as a common type (i.e. not specific to any
> device like the other typedefs that you move in this series), I think
> it's should be OK if this resides in typedefs.h ?
My idea was to clean files not very used, and this one is only used
twice. Why rebuild the World if someone add another function or fix a
typo in "qemu/range.h"?
I agree this typedef is meant for global use however.
Since I don't have a strong opinion, I'll drop it (until someone else
respond to this thread).
- Re: [Qemu-arm] [RFC PATCH 15/15] ui/console: Add "ui/pixelformat.h" to declare PixelFormat, (continued)
- [Qemu-arm] [PATCH 14/15] ui/console: Remove DisplayState/DisplaySurface from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 13/15] ui/console: Remove QemuDmaBuf from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 11/15] audio: Remove AudioState from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 12/15] ui/console: Remove MouseTransformInfo from qemu/typedefs.h, Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 09/15] hw/i386: Remove PCMachineClass from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 10/15] range: Remove Range from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 08/15] hw/char/serial: Remove SerialState from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 05/15] hw/nvram/fw_cfg: Remove various typedefs from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 06/15] hw/i2c/smbus: Remove SMBusDevice from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 07/15] hw/bt: Remove HCIInfo from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11
- [Qemu-arm] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h", Philippe Mathieu-Daudé, 2019/01/11