qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v4] Support u-boot noload images for


From: no-reply
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.
Date: Sun, 6 Jan 2019 14:56:38 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used 
by, NetBSD/evbarm GENERIC kernel.
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e2a15da Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC 
kernel.

=== OUTPUT BEGIN ===
Checking PATCH 1/1: Support u-boot noload images for arm as used by, 
NetBSD/evbarm GENERIC kernel....
ERROR: code indent should never use tabs
#89: FILE: hw/core/uboot_image.h:127:
+#define IH_TYPE_KERNEL_NOLOAD  14^I/* OS Kernel Image (noload)^I*/$

WARNING: line over 80 characters
#171: FILE: include/hw/loader.h:183:
+ * @loadaddr: load address if none specified in the image or when loading a 
ramdisk.

WARNING: line over 80 characters
#173: FILE: include/hw/loader.h:185:
+ *            LOAD_UIMAGE_LOADADDR_INVALID (images which do not specify a load 
address

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 2 warnings, 111 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]