qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH for-3.2 v4 16/28] hw: apply machine compat propert


From: Eduardo Habkost
Subject: Re: [Qemu-arm] [PATCH for-3.2 v4 16/28] hw: apply machine compat properties without touching globals
Date: Thu, 29 Nov 2018 14:09:34 -0200
User-agent: Mutt/1.9.2 (2017-12-15)

On Tue, Nov 27, 2018 at 01:27:49PM +0400, Marc-André Lureau wrote:
> Similarly to accel properties, move compat properties out of globals
> registration, and apply the machine compat properties during
> device_post_init().
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
[...]
> @@ -191,7 +190,7 @@ struct MachineClass {
>      const char *default_machine_opts;
>      const char *default_boot_order;
>      const char *default_display;
> -    GArray *compat_props;
> +    GPtrArray *compat_props;

What are the advantages/disadvantages of GArray vs GPtrArray vs
GList here?  Why did you decide to change this from GArray to
GPtrArray in v4?

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]