[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 5/8] hw: arm: Convert the RSDP bui
|
From: |
Andrew Jones |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API |
|
Date: |
Thu, 29 Nov 2018 15:28:57 +0100 |
|
User-agent: |
NeoMutt/20180716 |
On Thu, Nov 29, 2018 at 02:24:25PM +0100, Samuel Ortiz wrote:
> Instead of filling a mapped and packed C structure field in random order
> and being careful about endianness and sizes, build_rsdp() now uses
> build_append_int_noprefix() to compose RSDP table.
>
> This makes for an easier to review and maintain code that is almost
> matching 1:1 the ACPI spec itself.
>
> Signed-off-by: Samuel Ortiz <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 42 +++++++++++++++++++++-------------------
> 1 file changed, 22 insertions(+), 20 deletions(-)
Reviewed-by: Andrew Jones <address@hidden>
[Qemu-arm] [PATCH v2 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API, Samuel Ortiz, 2018/11/29
[Qemu-arm] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build, Samuel Ortiz, 2018/11/29
Re: [Qemu-arm] [PATCH v2 6/8] hw: arm: Support both legacy and current RSDP build, Igor Mammedov, 2018/11/30
[Qemu-arm] [PATCH v2 7/8] hw: acpi: Export and share the ARM RSDP build, Samuel Ortiz, 2018/11/29