[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/8] hw: acpi: The RSDP build API can
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/8] hw: acpi: The RSDP build API can return void |
Date: |
Mon, 26 Nov 2018 18:07:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 26/11/18 17:29, Samuel Ortiz wrote:
> For both x86 and ARM architectures, the internal RSDP build API can
> return void as the current return value is unused.
>
> Signed-off-by: Samuel Ortiz <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 4 +---
> hw/i386/acpi-build.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 5785fb697c..fcaa350892 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -367,7 +367,7 @@ static void acpi_dsdt_add_power_button(Aml *scope)
> }
>
> /* RSDP */
> -static GArray *
> +static void
> build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned xsdt_tbl_offset)
> {
> AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
> @@ -392,8 +392,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker,
> unsigned xsdt_tbl_offset)
> bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
> (char *)rsdp - rsdp_table->data, sizeof *rsdp,
> (char *)&rsdp->checksum - rsdp_table->data);
> -
> - return rsdp_table;
> }
>
> static void
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 236a20eaa8..35f17d0d91 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -2547,7 +2547,7 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker)
> "IVRS", table_data->len - iommu_start, 1, NULL, NULL);
> }
>
> -static GArray *
> +static void
> build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned rsdt_tbl_offset)
> {
> AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
> @@ -2569,8 +2569,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker,
> unsigned rsdt_tbl_offset)
> bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
> (char *)rsdp - rsdp_table->data, sizeof *rsdp,
> (char *)&rsdp->checksum - rsdp_table->data);
> -
> - return rsdp_table;
> }
>
> typedef
>
- [Qemu-arm] [PATCH 0/8] hw: acpi: RSDP fixes and refactoring, Samuel Ortiz, 2018/11/26
- [Qemu-arm] [PATCH 1/8] hw: acpi: The RSDP build API can return void, Samuel Ortiz, 2018/11/26
- [Qemu-arm] [PATCH 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP, Samuel Ortiz, 2018/11/26
- [Qemu-arm] [PATCH 3/8] hw: i386: Use correct RSDT length for checksum, Samuel Ortiz, 2018/11/26
- [Qemu-arm] [PATCH 5/8] hw: arm: Convert the RSDP build to the buid_append_foo() API, Samuel Ortiz, 2018/11/26
- [Qemu-arm] [PATCH 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData, Samuel Ortiz, 2018/11/26