qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH for-3.1] target/arm: Remove antique TODO comment


From: Alex Bennée
Subject: Re: [Qemu-arm] [PATCH for-3.1] target/arm: Remove antique TODO comment
Date: Mon, 12 Nov 2018 11:50:11 +0000
User-agent: mu4e 1.1.0; emacs 26.1.50

Peter Maydell <address@hidden> writes:

> Remove a TODO comment about implementing the vectored interrupt
> controller. We have had an implementation of that for a decade;
> it's in hw/intc/pl190.c.

Reviewed-by: Alex Bennée <address@hidden>

>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target/arm/helper.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index ec56becc394..851ea9aa977 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -8378,7 +8378,6 @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
>          return;
>      }
>
> -    /* TODO: Vectored interrupt controller.  */
>      switch (cs->exception_index) {
>      case EXCP_UDEF:
>          new_mode = ARM_CPU_MODE_UND;


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]