qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'c


From: Thomas Huth
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine
Date: Wed, 7 Nov 2018 20:39:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-11-07 17:08, Markus Armbruster wrote:
> Peter Maydell <address@hidden> writes:
> 
>> On 6 November 2018 at 18:52, Thomas Huth <address@hidden> wrote:
>>> On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote:
>>>> On 6/11/18 19:17, Thomas Huth wrote:
>>>>> There is no active maintainer, but since Peter is picking up
>>>>> patches via address@hidden, I think we could at least use
>>>>> "Odd Fixes" as status here.
>>>>
>>>> This looks more as "Orphan" to me...
>>>
>>> I'll leave it up to Peter for the final decision...
>>
>> I think we're not very consistent[*] in our usage of the various
>> statuses in the MAINTAINERS file. I guess "Odd Fixes" makes
>> sense in that, well, if you send a patch to this
>> code and cc me I'll review it and put it in the tree. (This
>> is true of any of the arm boards we have.)
>>
>> [*] We have one thing tagged Orphan, which is bsd-user/,
>> and some things tagged Odd Fixes with no listed maintainer,
>> and some things tagged Odd Fixes which are in practice more
>> like Orphan (for instance sh4), and we list "fpu/" as
>> Odd Fixes despite having given it a pretty thorough
>> overhaul very recently, and so on...
>>
>> If you wanted a mechanizable rule, you could try something
>> like "every file which is in status Odd Fixes or better
>> must list with M: at least one named individual who has
>> submitted a pull request in the last nine months" :-)
> 
> Sounds like an excellent idea to me!

Well, for me "odd fixes" means that there is someone around who might
pick up the patch and throw it into a PULL request. "Orphan" means it's
mostly in vain to send patches for this subsystem, since there is nobody
going to pick up your patch. So for the ARM boards, I'd say that "odd
fixes" is a better choice, since Peter still picks up most of the
patches via the "L: address@hidden" (big thanks for this, by the way!).

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]