[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property |
Date: |
Mon, 5 Nov 2018 15:33:40 +0000 |
On 2 November 2018 at 00:12, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/misc/bcm2835_property.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
> index 145427ae0f..5d332324bd 100644
> --- a/hw/misc/bcm2835_property.c
> +++ b/hw/misc/bcm2835_property.c
> @@ -121,6 +121,12 @@ static void
> bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
> resplen = 8;
> break;
>
> + case 0x00030030: /* domain state */
> + qemu_log_mask(LOG_UNIMP,
> + "bcm2835_property: %x get domain state NYI\n",
> tag);
> + resplen = 8;
> + break;
> +
Our handling of "Set power state" has a slightly more sophisticated
"always say yes" implementation, but we have other properties which
we handle unimplemented like this, so if the kernel is happy with
this we don't need to do anything more sophisticated.
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-arm] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem), Philippe Mathieu-Daudé, 2018/11/01
- [Qemu-arm] [PATCH for 3.2 v2 3/7] hw/arm/bcm2835: Use 0x prefix for hex numbers, Philippe Mathieu-Daudé, 2018/11/01
- [Qemu-arm] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property, Philippe Mathieu-Daudé, 2018/11/01
- Re: [Qemu-arm] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property,
Peter Maydell <=
- [Qemu-arm] [PATCH for 3.2 v2 5/7] hw/arm/bcm2835: Add various unimplemented peripherals, Philippe Mathieu-Daudé, 2018/11/01
- [Qemu-arm] [PATCH for 3.2 v2 4/7] hw/arm/bcm2835: Rename some definitions, Philippe Mathieu-Daudé, 2018/11/01
- [Qemu-arm] [PATCH for 3.2 v2 7/7] MAINTAINERS: Volunteer to review Raspi patches, Philippe Mathieu-Daudé, 2018/11/01
- [Qemu-arm] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines, Philippe Mathieu-Daudé, 2018/11/01