qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v4 03/23] hw: acpi: Export the RSDP b


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v4 03/23] hw: acpi: Export the RSDP build API
Date: Fri, 2 Nov 2018 10:56:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Hi,

On 2/11/18 10:20, Shannon Zhao wrote:
Hi,

On 2018/11/1 18:22, Samuel Ortiz wrote:
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f28a2faa53..0ed132b79b 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -367,7 +367,7 @@ static void acpi_dsdt_add_power_button(Aml *scope)
  }
  /* RSDP */
-static GArray *
+static void
  build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned xsdt_tbl_offset)
  {
      AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);

Why change this? It's not related to your patch purpose.

This patch updates include/hw/acpi/aml-build.h to export the build_rsdp() function.
Since this file includes this header, the orototype needs to match.

Regards,

Phil.


Thanks,
Shannon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]