qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v4 06/23] hw: acpi: Generalize AML build routines


From: Shannon Zhao
Subject: Re: [Qemu-arm] [PATCH v4 06/23] hw: acpi: Generalize AML build routines
Date: Fri, 2 Nov 2018 17:41:00 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0



On 2018/11/1 18:22, Samuel Ortiz wrote:
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 0a6a88380a..6822ee4eaa 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -546,7 +546,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, 
VirtMachineState *vms)
  }
static void
-build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
+virt_build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
  {
      AcpiTableMcfg *mcfg;
      const MemMapEntry *memmap = vms->memmap;
@@ -791,7 +791,7 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables 
*tables)
      build_gtdt(tables_blob, tables->linker, vms);
acpi_add_table(table_offsets, tables_blob);
-    build_mcfg(tables_blob, tables->linker, vms);
+    virt_build_mcfg(tables_blob, tables->linker, vms);
Looks like it doesn't share build_mcfg with x86. Why you still export the x86 build_mcfg and introduce this unnecessary change?

Thanks,
Shannon



reply via email to

[Prev in Thread] Current Thread [Next in Thread]