[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_i
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c |
|
Date: |
Tue, 30 Oct 2018 08:18:20 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote:
> +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq)
> +{
> + SysBusDevice *busdev;
> + DeviceState *dev;
> +
> + dev = qdev_create(NULL, TYPE_PL330);
> + qdev_prop_set_uint8(dev, "num_chnls", 8);
> + qdev_prop_set_uint8(dev, "num_periph_req", nreq);
> + qdev_prop_set_uint8(dev, "num_events", 16);
> + qdev_prop_set_uint8(dev, "data_width", 64);
> + qdev_prop_set_uint8(dev, "wr_cap", 8);
> + qdev_prop_set_uint8(dev, "wr_q_dep", 16);
> + qdev_prop_set_uint8(dev, "rd_cap", 8);
> + qdev_prop_set_uint8(dev, "rd_q_dep", 16);
> + qdev_prop_set_uint16(dev, "data_buffer_dep", 256);
> + qdev_init_nofail(dev);
> +
> + busdev = SYS_BUS_DEVICE(dev);
> + sysbus_mmio_map(busdev, 0, base);
> + sysbus_connect_irq(busdev, 0, irq);
> +}
Why is this inline instead of in hw/dma/pl300.c?
There should be nothing performance sensative here...
r~
Re: [Qemu-arm] [Qemu-devel] [PATCH 0/3] hw/arm/exynos4: Add DMA support for SMDKC210 board, no-reply, 2018/10/31