[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 06/14] target/arm: Filter cycle co
|
From: |
Aaron Lindsay |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0 |
|
Date: |
Tue, 16 Oct 2018 11:26:09 -0400 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Oct 16 08:25, Aaron Lindsay wrote:
> On Oct 15 13:51, Richard Henderson wrote:
> > On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> > > --- a/target/arm/machine.c
> > > +++ b/target/arm/machine.c
> > > @@ -584,7 +584,7 @@ static int cpu_pre_save(void *opaque)
> > > {
> > > ARMCPU *cpu = opaque;
> > >
> > > - pmccntr_op_start(&cpu->env);
> > > + pmu_op_start(&cpu->env);
> >
> > Does it make sense to move this patch earlier so that these hooks are
> > modified
> > once? No big deal if not.
I took another look at this, and I think it makes sense to move the
pmccntr_op -> pmu_op changes into "target/arm: Reorganize PMCCNTR
accesses", independent of the filtering changes.
-Aaron
- Re: [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, (continued)
[Qemu-arm] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0, Aaron Lindsay, 2018/10/10
[Qemu-arm] [PATCH v6 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01], Aaron Lindsay, 2018/10/10
[Qemu-arm] [PATCH v6 11/14] target/arm: PMU: Add instruction and cycle events, Aaron Lindsay, 2018/10/10
[Qemu-arm] [PATCH v6 13/14] target/arm: Implement PMSWINC, Aaron Lindsay, 2018/10/10