[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 05/13] target/arm: Add some comments
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 05/13] target/arm: Add some comments in Thumb decode |
Date: |
Wed, 3 Oct 2018 15:02:28 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/2/18 11:35 AM, Peter Maydell wrote:
> Add some comments to the Thumb decoder indicating what bits
> of the instruction have been decoded at various points in
> the code.
>
> This is not an exhaustive set of comments; we're gradually
> adding comments as we work with particular bits of the code.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Specifically, I figured these out as I was going through looking
> for the insns which write SP. These comments turn out not to
> be relevant to those instructions, but I don't want to throw
> them away.
> ---
> target/arm/translate.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 02/13] target/arm: Define new EXCP type for v8M stack overflows, (continued)
- [Qemu-arm] [PATCH 03/13] target/arm: Move v7m_using_psp() to internals.h, Peter Maydell, 2018/10/02
- [Qemu-arm] [PATCH 01/13] target/arm: Define new TBFLAG for v8M stack checking, Peter Maydell, 2018/10/02
- [Qemu-arm] [PATCH 05/13] target/arm: Add some comments in Thumb decode, Peter Maydell, 2018/10/02
- [Qemu-arm] [PATCH 04/13] target/arm: Add v8M stack checks on ADD/SUB/MOV of SP, Peter Maydell, 2018/10/02
- [Qemu-arm] [PATCH 06/13] target/arm: Add v8M stack checks on exception entry, Peter Maydell, 2018/10/02
- [Qemu-arm] [PATCH 09/13] target/arm: Add v8M stack checks for Thumb2 LDM/STM, Peter Maydell, 2018/10/02
- [Qemu-arm] [PATCH 07/13] target/arm: Add v8M stack limit checks on NS function calls, Peter Maydell, 2018/10/02